Skip to content

Add more animations, add AggregatePixels helper. #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 47 commits into from
May 15, 2020
Merged

Add more animations, add AggregatePixels helper. #10

merged 47 commits into from
May 15, 2020

Conversation

rhooper
Copy link

@rhooper rhooper commented Dec 16, 2019

Add more animations, add AggregatePixels helper, add names to animations, add random order, add cycle done callback.

@kattni kattni requested a review from a team December 18, 2019 14:50
@kattni
Copy link
Contributor

kattni commented Dec 18, 2019

Needs documentation improvements, and testing without pixelbuf (potentially on Raspberry Pi).

@rhooper
Copy link
Author

rhooper commented Jan 4, 2020

@kattni I don't know how to resolve this error... Some help would be great.

Warning, treated as error:
/home/runner/work/Adafruit_CircuitPython_LED_Animation/Adafruit_CircuitPython_LED_Animation/docs/index.rst:17:toctree contains reference to document 'api' that doesn't have a title: no link will be generated
##[error]Process completed with exit code 2.

@rhooper rhooper closed this Jan 19, 2020
@rhooper rhooper reopened this Feb 1, 2020
@rhooper rhooper mentioned this pull request Feb 20, 2020
Merged
@siddacious
Copy link

@rhooper @kattni What's the status of this? Looks like it needs to be rebased or otherwise synched, but is this good to go otherwise?

@kattni
Copy link
Contributor

kattni commented May 1, 2020

@siddacious There is a significant amount of cleanup needed, not including the rebase, before it can be merged. It was waiting on all of the other pixel stuff to be settled which only happened yesterday. Limor asked that I wait to do anything with it until all of that was taken care of, and obviously the situation changed in the meantime. Please leave this open for now.

kattni and others added 23 commits May 8, 2020 14:49
@kattni
Fix import, add licenses, docstrings.
facd447
@kattni
Hello darkness my old friend.
21ca6b9
@rhooper
Make RainbowChase work, and make Chase code easier to work with via g…
9398874 
…enerators
@rhooper
fix lint
3277e4d
@rhooper
add rainbowcomet
cd7783f
@kattni
Update Aggregate and Subset naming.
6f17a43
@kattni
Add NotifiedAnimationSequence, remove color from Rainbow*
b8fe94a
@rhooper
Refactor cycle completion notification system
d66c999
@rhooper
fix auto advance
12cceda
@rhooper
refactor group and sequence notifications, add the ability to loop mu…
00133ed 
…ltiple times to groups, sequences, and animations
@rhooper
bugfixes
4399fb4
@rhooper
fix a bug
a81ee24
@rhooper
fix various bugs, duplicate show calls, and other fixes
ab085fd
@kattni
Update simpletest to new API.
5bd6bfe
@rhooper
Make generics to help with vertical and horizontal lines.
cf4a1fe
@rhooper
reformat code to comply with black
496e46c
@kattni
Appease the Sphinx.
6dd47d5
@rhooper
fix error related to cycle_complete_supported in some animations
ee35ea8
@kattni
Examples and docs.
ed4bbf9
@kattni
Import fix.
98da8ab
@rhooper
split up into more files to make it possible to use some animations o…
4c44276 
…n M0
@rhooper
remove pixelmap add
0dc7599
@kattni
Still needs docstrings in new files.
b0206e9
FoamyGuy
FoamyGuy approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the all 3 examples successfully on a Pybadge, a Circuit Playground Bluefruit and a RasPi 3 B+.

led_animation_simpletest.py works on Metro M0 Express but he other two examples have memory error.

One minor issue on the Rasperry Pi 3 B+ the rainbow_comet animations was not working on that device for me. No errors or anything, pixels all stayed off during that animation.

One minor suggestion: slow down default speed for the the blink animation in the led_animation_all_animations.py so it's not flashing so fast out of the gate.

I don't think either are major enough to block merging though.

Thank you Roy and Kattni for working on this very cool library!

@kattni kattni merged commit 2c3025d into adafruit:master May 15, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 18, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@c5c3fcd)
bbc68dd 
Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.0.0 from 1.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#21 from kattni/doc-example-update
  > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#20 from kattni/refactor
  > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#19 from kattni/update-blink-speed-example
  > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#10 from rhooper/more-magic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rhooper @kattni @siddacious @FoamyGuy